Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: switch from using extras to dependency groups #330

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jan 23, 2025

This switches from using extras to using dependency groups, now that they are considered standard.

It also adjusts the readthedocs build to use uv so that we can use those groups, with a side effect of speeding up the RTD builds (more noticeable here than in bigger projects).

As a drive-by, it also fixes the PR template.

This is marked as a breaking change because the changes to pyproject.toml and common.mk are mutually dependent.

Now that PEP 735 is finalised and we have a standard for dependency
groups, we should move away from using extras to using those.

https://packaging.python.org/en/latest/specifications/dependency-groups/
This adjusts the readthedocs to use uv, which speeds up the RTD build
time fairly significantly. The old RTD configuration also would not work
now that we've moved from extras to dependency groups.
@lengau lengau changed the title build: switch from using extras to dependency groups build!: switch from using extras to dependency groups Jan 23, 2025
@lengau lengau requested a review from a team January 23, 2025 01:19
pyproject.toml Show resolved Hide resolved
common.mk Show resolved Hide resolved
common.mk Show resolved Hide resolved
.readthedocs.yaml Show resolved Hide resolved
@sergiusens
Copy link
Collaborator

All for this!

@lengau lengau requested a review from upils January 27, 2025 17:12
@lengau lengau merged commit 0bb0106 into main Jan 28, 2025
11 checks passed
@lengau lengau deleted the uv-groups branch January 28, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants