-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISD-2761 Add oauth lib and requirer #621
base: 2/main
Are you sure you want to change the base?
Conversation
…l/synapse-operator into install_mas_cli_in_synapse_rock
…l/synapse-operator into install_mas_cli_in_synapse_rock
…ery slight chance that the generated secret contains all digits and is interpreted as an unsigned int
…apse-operator into add_oauth_lib_and_requirer
could you update the pull request description? Thanks! |
…apse-operator into add_oauth_lib_and_requirer
Test coverage for 3d2c1b6
Static code analysis report
|
…apse-operator into add_oauth_lib_and_requirer
…apse-operator into add_oauth_lib_and_requirer
Hi @gregory-schiano / @amandahla, can you take a look and review the PR when you have the time? thanks! |
"-c", | ||
MAS_CONFIGURATION_PATH, | ||
"manage", | ||
"provision-all-users", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this job have any impact on MAS?
Also, should this be run after every restart too?
oauth_client_config = generate_oauth_client_config( | ||
mas_configuration, charm_state.synapse_config | ||
) | ||
self._oauth.update_client_config(oauth_client_config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt this trigger another relation-changed?
Add the oidc interface to configure
upstream_providers
in MAS.Checklist
src-docs
urgent
,trivial
,complex
)