Lock pymongo to version < 4.9.0 - fails to start with newer versions #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boukeas
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Varun pointed out that he was having trouble getting testflinger to start a few days ago. It looks like it's due to a change in pymongo recently, which is pulled in by flask-pymongo. I think the latest pymongo might break some things with GridFS (though I haven't tested it out completely yet), but it definitely breaks some things for us with both flask-pymongo and mongomock. For now, let's avoid the update until all of them play nice together again.
Resolved issues
I'm logging an issue for this, but we shouldn't close it with this patch. This is just a temporary fix to keep Testflinger functioning for now.
Documentation
N/A
Web service API changes
N/A
Tests
Confirmed that rebuilding the OCI and running it still works after this patch. But this is the version we've been using for a while now, so it just keeps what's already in production.