Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: copy SSH keys at the end of zapper_iot provisioning #446

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add: copy SSH keys at the end of zapper_iot provisioning #446

merged 2 commits into from
Jan 15, 2025
+39 −29

Conversation

p-gentili
Copy link
Contributor

@p-gentili p-gentili commented Jan 14, 2025 •
edited
Loading

Description

Copy the agent SSH keys at the end of zapper_iot provisioning.

Resolved issues

N/A

Documentation

N/A

Web service API changes

N/A

Tests

https://testflinger.canonical.com/jobs/5dcf9f9f-982b-4722-96e0-daa0ed691eca

@p-gentili p-gentili requested a review from kiya956 January 14, 2025 09:41
@kiya956
Copy link
Contributor

kiya956 commented Jan 14, 2025

I saw the same action in the test stage in task yaml, are we plan to move the copying to the provision stage?

@p-gentili
Copy link
Contributor Author

I saw the same action in the test stage in task yaml, are we plan to move the copying to the provision stage?

That's just a way to test provision from this branch: I'm running the provision method with testflinger-device-connector zapper_iot provision.

I'm running the job again because it failed (missing sshpass I guess).

@kiya956
Copy link
Contributor

kiya956 commented Jan 15, 2025

I saw the same action in the test stage in task yaml, are we plan to move the copying to the provision stage?

That's just a way to test provision from this branch: I'm running the provision method with testflinger-device-connector zapper_iot provision.

I'm running the job again because it failed (missing sshpass I guess).

Got that!!

kiya956
kiya956 previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kiya956 kiya956 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-gentili p-gentili force-pushed the always-copy-ssh-keys branch 2 times, most recently from 4eda8e7 to 1e97054 Compare January 15, 2025 07:21
@p-gentili
Copy link
Contributor Author

Latest test run: https://testflinger.canonical.com/jobs/8e133403-19eb-4910-b309-4118ebafe330
it fails becase ssh-copy-id is not possible in test phase (check log for confirmation). It'll be an option in provision phase, so this should be good to go.

@p-gentili p-gentili force-pushed the always-copy-ssh-keys branch from 1e97054 to 6689e81 Compare January 15, 2025 07:24
kiya956
kiya956 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kiya956 kiya956 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiya956 kiya956 marked this pull request as ready for review January 15, 2025 07:27
@kiya956 kiya956 requested a review from a team as a code owner January 15, 2025 07:27
@p-gentili p-gentili merged commit 167ed0f into main Jan 15, 2025
2 checks passed
@p-gentili p-gentili deleted the always-copy-ssh-keys branch January 15, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiya956 kiya956 kiya956 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-gentili @kiya956