Prevent usage newer evdev than 0.11.3 due to compilation error for armv7 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was about to make a PR to evdev to fix the source issue, but found that their current master branch builds fine. It seems this already got addressed in a commit 9 days ago, but there is no release with this fix yet. PR: emberian/evdev#96 So this fix should do the trick until the next release of evdev fixes the issue. If it's a patch release ( Will merge this tomorrow of no one is against this (cc @bkirwi @fenollp ) |
|
I'm all for it - thanks for handling!
…On Thu, Sep 1, 2022 at 08:05 Linus K. ***@***.***> wrote:
Was about to make a PR to evdev to fix the source issue, but found that
their current master branch builds fine. It seems this already got
addressed in a commit 9 days ago, but there is no release with this fix yet.
PR: emberian/evdev#96 <emberian/evdev#96>
Commit: ***@***.***
<emberian/evdev@909b3d2>
So this fix should do the trick until the next release of evdev fixes the
issue. If it's a patch release (0.12.X) we should probably use >= for the
version to ensure no accidental use of 0.12.0.
Will merge this tomorrow of no one is against this (cc @bkirwi
<https://github.com/bkirwi> @fenollp <https://github.com/fenollp> )
—
Reply to this email directly, view it on GitHub
<#107 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFXMZUBEYVP5UGP6LM27DV4CLEXANCNFSM6AAAAAAQCI2EDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fenollp
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #106 by capping the version of evdev used for now.
I also tested with the newer minor version (0.12.0) and it had the same issue as well.