Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isValid() doesn't work on nested fields #153

Closed
joedj opened this issue Jan 7, 2015 · 2 comments
Closed

isValid() doesn't work on nested fields #153

joedj opened this issue Jan 7, 2015 · 2 comments
Assignees
Labels

Comments

@joedj
Copy link

joedj commented Jan 7, 2015

Validation errors are detected in nested fields, but isValid() returns true and handle() fires the success callback rather than the error callback. Is this supposed to be a supported feature?

Test case here: https://gist.github.com/joedj/00845444f6185de4b93a

git clone https://gist.github.com/00845444f6185de4b93a.git nested-fields
cd nested-fields
npm install
node test.js
@ljharb ljharb self-assigned this Jan 7, 2015
ljharb added a commit that referenced this issue Jan 7, 2015
@ljharb ljharb closed this as completed in fbb4e5d Jan 7, 2015
@ljharb
Copy link
Collaborator

ljharb commented Jan 7, 2015

Released as v1.1.1.

Thanks a lot for the amazingly helpful gist, test case, and issue text - if all bugs were submitted this way there wouldn't be any left :-)

@ljharb ljharb added the Bugs label Jan 7, 2015
@joedj
Copy link
Author

joedj commented Jan 7, 2015

Wow, that was quick. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants