Merge pull request #340 from steved/sdavidovitz/warnings

Silence interpreter warnings
capistrano · Mar 18, 2016 · 6a94cdc · 6a94cdc
2 parents c9c4ab1 + 821264c
commit 6a94cdc
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/lib/sshkit.rb b/lib/sshkit.rb
@@ -4,7 +4,7 @@ module SSHKit
 
   class << self
 
-    attr_accessor :config
+    attr_writer :config
 
     def configure
       @@config ||= Configuration.new

diff --git a/lib/sshkit/backends/connection_pool.rb b/lib/sshkit/backends/connection_pool.rb
@@ -78,10 +78,12 @@ def close_connections
     end
   end
 
-  private
+  protected
 
   attr_reader :caches, :timed_out_connections
 
+  private
+
   def cache_enabled?
     idle_timeout && idle_timeout > 0
   end

diff --git a/lib/sshkit/backends/connection_pool/cache.rb b/lib/sshkit/backends/connection_pool/cache.rb
@@ -53,10 +53,12 @@ def clear
     end
   end
 
-  private
+  protected
 
   attr_reader :connections, :idle_timeout, :closer
 
+  private
+
   def fresh?(expires_at)
     expires_at > Time.now
   end

diff --git a/lib/sshkit/backends/netssh.rb b/lib/sshkit/backends/netssh.rb
@@ -5,6 +5,8 @@ module Net
   module SSH
     class Config
       class << self
+        remove_method :default_files
+
         def default_files
           @@default_files + [File.join(Dir.pwd, '.ssh/config')]
         end

diff --git a/lib/sshkit/configuration.rb b/lib/sshkit/configuration.rb
@@ -2,7 +2,7 @@ module SSHKit
 
   class Configuration
 
-    attr_accessor :umask, :output_verbosity
+    attr_accessor :umask
     attr_writer :output, :backend, :default_env, :default_runner
 
     def output

diff --git a/lib/sshkit/host.rb b/lib/sshkit/host.rb
@@ -99,7 +99,7 @@ def properties
   class SimpleHostParser
 
     def self.suitable?(host_string)
-      !host_string.match(/[:|@]/)
+      !host_string.match(/:|@/)
     end
 
     def initialize(host_string)
@@ -127,7 +127,7 @@ def attributes
   class HostWithPortParser < SimpleHostParser
 
     def self.suitable?(host_string)
-      !host_string.match(/[@|\[|\]]/)
+      !host_string.match(/@|\[|\]/)
     end
 
     def port