-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cp_r in local backend with recursive option #372
Conversation
Thanks for the patch @okuramasafumi we'll need a test to verify this as working, and as you're working in this area, you may want to fix the build, which is currently failing because |
@leehambley OK, I'll change variable name from |
@leehambley Btw, do you have a plan for a |
You ought to be able to use the stubbing from the test framework, it's a fairly simple unit test that the method was called, I don't think we need to test the standard library behaves correctly! |
Sorry for the delay, I fixed the test so please check this again! |
Hi @okuramasafumi, thanks again for the PR! I don't see the test that you mentioned. Can you make sure all your changes have been pushed? |
@mattbrictson I added tests and squashed commits. |
Excellent work! Thanks ✨ |
## [1.13.1][] (2017-03-31) ### Breaking changes * None ### Bug fixes * [#397](https://github.com/capistrano/sshkt/pull/397): Fix NoMethodError assign_defaults with net-ssh older than 4.0.0 - [@shirosaki](https://github.com/shirosaki) ## [1.13.0][] (2017-03-24) ### Breaking changes * None ### New features * [#372](capistrano/sshkit#372): Use cp_r in local backend with recursive option - [@okuramasafumi](https://github.com/okuramasafumi) ### Bug fixes * [#390](capistrano/sshkit#390): Properly wrap Ruby StandardError w/ add'l context - [@mattbrictson](https://github.com/mattbrictson) * [#392](capistrano/sshkit#392): Fix open two connections with changed cache key - [@shirosaki](https://github.com/shirosaki)
When
recursive
optionforupload!
method is true,local
argument is likely to be a String representing a directory, butFileUtils.cp
doesn't accept it. So here we useFileUtils.cp_r
instead.