Add diff to TextColumn #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-yin
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden,
JGSweets and
lettergram
as code owners
grant-eden
reviewed
Jun 29, 2021
auto-merge was automatically disabled
June 30, 2021 15:23
Head branch was pushed to by a user without write access
grant-eden
previously approved these changes
Jun 30, 2021
grant-eden
previously approved these changes
Jun 30, 2021
grant-eden
approved these changes
Jun 30, 2021
AnhTruong
approved these changes
Jun 30, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* Add text diff and tests * Update parent call to diff * Simplify tests * Simplied vocab test check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextColumn inherits most diff properties from NumericalStatsMixin, so all that's needed to do is add vocab to it.