Add text size to unstructured profiler #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnhTruong
commented
Jul 16, 2021
AnhTruong
commented
- add capacity to global stats
- add tests
AnhTruong
requested review from
lettergram,
JGSweets,
ChrisWallace2020 and
grant-eden
JGSweets
reviewed
Jul 16, 2021
JGSweets
reviewed
Jul 16, 2021
JGSweets
added
Medium Priority
JGSweets
reviewed
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
JGSweets
previously approved these changes
Jul 19, 2021
grant-eden
reviewed
Jul 19, 2021
grant-eden
reviewed
Jul 19, 2021
dataprofiler/profilers/utils.py
Outdated
| :type data: Union[list, numpy.array, pandas.DataFrame] | ||
| :param unit: capacity unit (B, K, M, or G) | ||
| :type unit: string | ||
| :return: capacity of the input data |
There was a problem hiding this comment.
need to update docstring to get rid of capacity
grant-eden
reviewed
Jul 19, 2021
| } | ||
|
|
||
| # ensure all data are of type str | ||
| data = data.apply(str) | ||
|
|
||
| # get capacity | ||
| base_stats = {"memory_size": utils.get_capacity(data, unit='M')} |
There was a problem hiding this comment.
This is still called capacity
JGSweets
reviewed
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
JGSweets
previously approved these changes
Jul 19, 2021
grant-eden
previously approved these changes
Jul 19, 2021
JGSweets
reviewed
Jul 19, 2021
dataprofiler/profilers/utils.py
Outdated
| @@ -504,8 +504,39 @@ def get_memory_size(data, unit='M'): | |||
| if unit not in unit_map: | |||
| raise ValueError('Currently only supports the ' | |||
| 'memory size unit in {}'.format(list(unit_map.keys()))) | |||
| capacity = 0 | |||
| memory_size = 0 | |||
grant-eden
previously approved these changes
Jul 19, 2021
JGSweets
approved these changes
Jul 19, 2021
grant-eden
approved these changes
Jul 19, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
* add text size * add error raise for unit * clean code * clean test * fix test * clean test * clean test * clean test * clean test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.