Buffer issue and cleanup tests pep8 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
added
Bug
JGSweets
requested review from
AnhTruong,
ChrisWallace2020,
grant-eden and
lettergram
as code owners
JGSweets
commented
Jul 21, 2021
| if isinstance(input_buf['path'], BytesIO): | ||
| input_buf['path'] = TextIOWrapper(input_buf['path'], encoding=input_buf['encoding']) |
There was a problem hiding this comment.
this was a bug replacing the value in the dict as oppose to maintaining the BytesIO.
ChrisWallace2020
approved these changes
Jul 21, 2021
AnhTruong
approved these changes
Jul 21, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer was being replaced due to mutability, this fixes the bug if tests are not parallelized