Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List now maintains same visual data representation #363

Merged
merged 3 commits into from
Jul 28, 2021
Merged

List now maintains same visual data representation #363

merged 3 commits into from
Jul 28, 2021

Conversation

JGSweets
Copy link
Contributor

@JGSweets JGSweets commented Jul 27, 2021 •
edited
Loading

Previously if inputing list into the profiler, the data representation would change ints to floats when illustrating samples:

import dataprofiler as dp

data = [1, 2, None]
profiler = dp.Profiler(data)

# output would have: ['1.0', '2.0'] as opposed to ['1', '2']
print(profiler.profile[0].sample)

This fixes that to show the latter repsentation.

@ChrisWallace2020 ChrisWallace2020 enabled auto-merge (squash) July 27, 2021 19:08
@JGSweets JGSweets added Bug Something isn't working Work In Progress Solution is being developed labels Jul 27, 2021
@JGSweets
Copy link
Contributor Author

Bug for 2D data as input. need to continue refactoring

@JGSweets JGSweets removed the Work In Progress Solution is being developed label Jul 27, 2021
@ChrisWallace2020 ChrisWallace2020 merged commit dba2d12 into capitalone:main Jul 28, 2021
stevensecreti pushed a commit to stevensecreti/DataProfiler that referenced this pull request Jun 15, 2022
@JGSweets
fix: list now maintains same visual data representation (capitalone#363)
cf78296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant-eden grant-eden grant-eden approved these changes

@ChrisWallace2020 ChrisWallace2020 ChrisWallace2020 approved these changes

@AnhTruong AnhTruong Awaiting requested review from AnhTruong

@lettergram lettergram Awaiting requested review from lettergram

Assignees

@ChrisWallace2020 ChrisWallace2020

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JGSweets @ChrisWallace2020 @grant-eden