Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphProfiler: add() NotImplementedError #636

Merged
merged 6 commits into from
Sep 19, 2022
Merged

GraphProfiler: add() NotImplementedError #636

merged 6 commits into from
Sep 19, 2022

Conversation

micdavis
Copy link
Contributor

  • Set __add__() to raise NotImplementedError
  • made bug fix and updated tests

taylorfturner
taylorfturner previously requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotImplementedError as function

JGSweets
JGSweets previously approved these changes Sep 16, 2022
View reviewed changes
@taylorfturner taylorfturner enabled auto-merge (squash) September 16, 2022 20:59
@taylorfturner taylorfturner enabled auto-merge (squash) September 19, 2022 13:26
@taylorfturner taylorfturner merged commit 13bca1e into capitalone:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksneab7 ksneab7 ksneab7 approved these changes

@taylorfturner taylorfturner taylorfturner approved these changes

@JGSweets JGSweets JGSweets left review comments

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micdavis @JGSweets @taylorfturner @ksneab7