Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding
PSI
todiff
report #688Adding
PSI
todiff
report #688Changes from all commits
f6be48b
336a8a2
7584838
3394a0f
4b4f165
0358ecc
eae37b5
2a19fc1
3ce26cf
c311ebc
b92793b
4a3f34d
f418d5f
66c4122
6a534aa
943def3
fd2e425
b439472
be4ed9a
5a7397b
ba325cf
c004a6f
e1b62e4
bfa0042
007be39
9a7fc67
db590af
a989132
42f0cd0
ec219f2
90bd46f
254a4ef
0579092
9fdb9b4
aab0ea1
b75f140
a2353fb
b107534
b5d14f8
6ec3dc4
a74b357
abaf3fc
8218bbd
df1e81a
02f1271
6fd8865
10db92f
ef6cd36
7da765f
4a1514e
040ce6d
1a2db04
e1d367e
251dff7
53e7355
54ca76f
2730d0b
a7b0d46
33b1710
19cdd35
b3672aa
e2fba6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broke out
_histogram_for_profile()
function into two functions in the code so that we could call_regenerate_histogram
on eitherself
orother_profile
.The idea here is that to calculate PSI the edges in the historgram need to be the same between
self
andother_profile
. In order to accomplish, prior to calling_calculate_psi
potentially one or bothobj._stored_histograms
need to be updated.This is the purpose of the refactor and breaking out into
_regenerate_histogram
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling
_regenerate_histogram
here now. The old code in the function is now indef _regenerate_histogram()
.