-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile to auto setup repo for developers #699
Changes from 11 commits
28b67ca
c1b4d60
ff6c495
4318d20
f6d3da6
03a2529
8a5465e
6542e77
505c5c6
00b5b88
ca305d0
81a4f2c
8ee8b04
56f672e
0625299
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
setup: requirements.txt requirements-dev.txt requirements-test.txt | ||
python3 -m venv venv | ||
|
||
. venv/bin/activate; \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should these end with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is bc the last line has There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tonywu315 I would test locally this rec from @JGSweets ... I tested it one way but didn't work on my end There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It works for me if I remove the |
||
pip install -r requirements.txt; \ | ||
pip install -r requirements-dev.txt; \ | ||
pip install -r requirements-test.txt; \ | ||
pip install -e .; \ | ||
pre-commit install; \ | ||
pre-commit run; \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we make a section for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could. I see this as just an initial implementation that improves the user experience -- one command to set their environment up, but I'll defer to @tonywu315 as the author of the PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. last line shouldn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to also include the other makefile components in readme