Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row statistics option documentation #883

Conversation

drahc1R
Copy link
Contributor

@drahc1R drahc1R commented Jun 15, 2023

No description provided.

@taylorfturner taylorfturner added the Documentation Improvements or additions to documentation label Jun 15, 2023
@drahc1R drahc1R changed the base branch from main to dev-gh-pages June 15, 2023 20:15
@drahc1R drahc1R changed the base branch from dev-gh-pages to feature/dev-gh-pages/options June 15, 2023 20:16
@taylorfturner taylorfturner enabled auto-merge (squash) June 15, 2023 20:17
docs/source/profiler.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@JGSweets JGSweets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add the extra details around unique_count

auto-merge was automatically disabled June 15, 2023 21:05

Head branch was pushed to by a user without write access

@drahc1R
Copy link
Contributor Author

drahc1R commented Jun 15, 2023

saw that base option was of dict type whoops

docs/source/profiler.rst Outdated Show resolved Hide resolved
@taylorfturner taylorfturner enabled auto-merge (squash) June 16, 2023 14:02
auto-merge was automatically disabled June 16, 2023 14:56

Head branch was pushed to by a user without write access

@JGSweets JGSweets enabled auto-merge (squash) June 19, 2023 22:30
labeler
* **correlation** - option set for correlation profiling
* is_enabled - (Boolean) Enables or disables performing correlation profiling
* columns - Columns considered to calculate correlation
* **row_statistics** - (Boolean) Option to enable/disable row statistics calculations
* unique_count - (Boolean) Option to enable/disable functionalities from UniqueCountOptions
* hashing_method - (String) Property to specify row hashing method ("full" | "hll")
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when "hll" is the selected hashing_method)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when "hll" is the selected hashing_method)
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when `hll` is the selected hashing_method)

auto-merge was automatically disabled June 20, 2023 12:47

Head branch was pushed to by a user without write access

labeler
* **correlation** - option set for correlation profiling
* is_enabled - (Boolean) Enables or disables performing correlation profiling
* columns - Columns considered to calculate correlation
* **row_statistics** - (Boolean) Option to enable/disable row statistics calculations
* unique_count - (Boolean) Option to enable/disable functionalities from UniqueCountOptions
* hashing_method - (String) Property to specify row hashing method ("full" | "hll")
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when `hll` is the selected hashing_method)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when `hll` is the selected hashing_method)
* hll - (HyperLogLogOptions) Options for alternative method of estimating unique row count (activated when `hll` is the selected hashing_method)

* unique_count - (Boolean) Option to enable/disable functionalities from UniqueCountOptions
* hashing_method - (String) Property to specify row hashing method ("full" | "hll")
* hll - (HyperLogLogOptions) Options for alternative method of gathering unique row count (activated when `hll` is the selected hashing_method)
* seed - (Int) Used to set HLL hashing function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* seed - (Int) Used to set HLL hashing function
* seed - (Int) Used to set HLL hashing function seed

@taylorfturner taylorfturner enabled auto-merge (squash) June 20, 2023 13:47
labeler
* **correlation** - option set for correlation profiling
* is_enabled - (Boolean) Enables or disables performing correlation profiling
* columns - Columns considered to calculate correlation
* **row_statistics** - (Boolean) Option to enable/disable row statistics calculations
* unique_count - (Boolean) Option to enable/disable functionalities from UniqueCountOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* unique_count - (Boolean) Option to enable/disable functionalities from UniqueCountOptions
* unique_count - (UniqueCountOptions) Option to enable/disable functionalities from UniqueCountOptions

Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

auto-merge was automatically disabled June 20, 2023 13:59

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner enabled auto-merge (squash) June 20, 2023 14:09
@@ -806,12 +806,19 @@ Below is an breakdown of all the options.
* data_labeler_dirpath - (String) Directory path to data labeler
* data_labeler_object - (BaseDataLabeler) Datalabeler to replace
the default labeler
* max_sample_size - (Int) The max number of samples for the data
* max_sample_size - (Int) The max number of samples for the data
labeler
* **correlation** - option set for correlation profiling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **correlation** - option set for correlation profiling
* **correlation** - Option set for correlation profiling

labeler
* **correlation** - option set for correlation profiling
* is_enabled - (Boolean) Enables or disables performing correlation profiling
* columns - Columns considered to calculate correlation
* **row_statistics** - (Boolean) Option to enable/disable row statistics calculations
* unique_count - (UniqueCountOptions) Option to enable/disable functionalities from UniqueCountOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* unique_count - (UniqueCountOptions) Option to enable/disable functionalities from UniqueCountOptions
* unique_count - (UniqueCountOptions) Option to enable/disable unique row count calculations

auto-merge was automatically disabled June 20, 2023 14:22

Head branch was pushed to by a user without write access

@taylorfturner taylorfturner merged commit 87d5cff into capitalone:feature/dev-gh-pages/options Jun 20, 2023
taylorfturner pushed a commit that referenced this pull request Jun 27, 2023
* updated documentation on new row_statistic options

* added documentation for row_statistics_options

* fixed typing of hll and included the note that it activates when hll is chosen as the hashing method

* removed space

* fixed quotation mark

* added micdavis comments

* fixed doc descriptions for unique_count

* small changes to docs

---------

Co-authored-by: JGSweets <[email protected]>
micdavis pushed a commit that referenced this pull request Jun 27, 2023
* reset ignore, update .gitignore, update documentation on presets (#874)

* reset ignore

* taylor's requested change

* taylor's requested change

* Fixed documentation for `sampling_ratio` option (#873)

* Add documentation for `sampling_ratio` option

* Update `sample_ratio` to `sampling_ratio` in documentations

Co-authored-by: Taylor Turner <[email protected]>

* Update `sampling_ratio` documentation

Co-authored-by: Taylor Turner <[email protected]>

* Update `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

---------

Co-authored-by: Taylor Turner <[email protected]>

* update (#882)

* Add documentation for `median_abs_deviation` option (#881)

* Add documentation for `median_abs_deviation` option

* Updated `median_abs_deviation` documentation

* Row statistics option documentation (#883)

* updated documentation on new row_statistic options

* added documentation for row_statistics_options

* fixed typing of hll and included the note that it activates when hll is chosen as the hashing method

* removed space

* fixed quotation mark

* added micdavis comments

* fixed doc descriptions for unique_count

* small changes to docs

---------

Co-authored-by: JGSweets <[email protected]>

* rendering issue

* rendering issue

* update to fix rendering

---------

Co-authored-by: Liz Smith <[email protected]>
Co-authored-by: clee1152 <[email protected]>
Co-authored-by: Richard Bann <[email protected]>
Co-authored-by: JGSweets <[email protected]>
JGSweets added a commit that referenced this pull request Jun 30, 2023
* documentation update for cms specific options to category (#917)

* add cms specific options to category

* address formatting requests

* address formatting requests

* Documentation: Update for Reservoir Sampling (#919)

* update option for reservoir sampling

* update for clarity rendering

* Documentation: feature/options branch docs updates (#921)

* reset ignore, update .gitignore, update documentation on presets (#874)

* reset ignore

* taylor's requested change

* taylor's requested change

* Fixed documentation for `sampling_ratio` option (#873)

* Add documentation for `sampling_ratio` option

* Update `sample_ratio` to `sampling_ratio` in documentations

Co-authored-by: Taylor Turner <[email protected]>

* Update `sampling_ratio` documentation

Co-authored-by: Taylor Turner <[email protected]>

* Update `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

---------

Co-authored-by: Taylor Turner <[email protected]>

* update (#882)

* Add documentation for `median_abs_deviation` option (#881)

* Add documentation for `median_abs_deviation` option

* Updated `median_abs_deviation` documentation

* Row statistics option documentation (#883)

* updated documentation on new row_statistic options

* added documentation for row_statistics_options

* fixed typing of hll and included the note that it activates when hll is chosen as the hashing method

* removed space

* fixed quotation mark

* added micdavis comments

* fixed doc descriptions for unique_count

* small changes to docs

---------

Co-authored-by: JGSweets <[email protected]>

* rendering issue

* rendering issue

* update to fix rendering

---------

Co-authored-by: Liz Smith <[email protected]>
Co-authored-by: clee1152 <[email protected]>
Co-authored-by: Richard Bann <[email protected]>
Co-authored-by: JGSweets <[email protected]>

* fix req tornado (#922)

* Merge `staging/dev-gh-pages/profile-serialization` into `dev-gh-pages` (#937)

* Docs: Profiler Serialization (#928)

* added info to profile save and load func

* addressed PR comments

* fixed formatting

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <[email protected]>

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <[email protected]>

---------

Co-authored-by: Taylor Turner <[email protected]>

* fixed formatting in docs (#936)

---------

Co-authored-by: Taylor Turner <[email protected]>

* Staging update docs 0.10.0  (#945)

* update or 0.10.0 docs version release

* empty

---------

Co-authored-by: Tyler <[email protected]>
Co-authored-by: Liz Smith <[email protected]>
Co-authored-by: clee1152 <[email protected]>
Co-authored-by: Richard Bann <[email protected]>
Co-authored-by: JGSweets <[email protected]>
Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants