refactor: cleanup dead code and some bug fixes #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
G3root
commented
Mar 4, 2024
| import { type Metadata } from "next"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "OpenCap - Sign Up", |
There was a problem hiding this comment.
we don't need a signup page now
G3root
commented
Mar 4, 2024
| @@ -6,7 +6,7 @@ type ProviderProps = { | |||
| children: React.ReactNode; | |||
| }; | |||
|
|
|||
| const ProgressBarProvider = ({ children }: ProviderProps) => { | |||
There was a problem hiding this comment.
refactored inside providers folder
G3root
commented
Mar 4, 2024
| async redirects() { | ||
| return [ | ||
| { | ||
| source: "/", |
There was a problem hiding this comment.
remove double redirect. now the redirection is handle inside the home page
G3root
changed the title
G3root
commented
Mar 4, 2024
| /usr/bin/mc config host add myminio http://minio:9002 opencap password; | ||
| /usr/bin/mc mb myminio/opencap; | ||
| /usr/bin/mc mb myminio/opencap-public; | ||
| /usr/bin/mc anonymous set public myminio/opencap-public; |
There was a problem hiding this comment.
creates private bucket and public bucket
G3root
commented
Mar 4, 2024
|
|
||
| const s3BaseURL = `https://${env.PUBLIC_UPLOAD_BUCKET}.s3.amazonaws.com`; |
There was a problem hiding this comment.
fixes hard coding of aws url and accessing env variables in client side error.
G3root
changed the title
G3root
commented
Mar 4, 2024
| import { Button } from "@/components/ui/button"; | ||
| import { Input } from "@/components/ui/input"; | ||
| import { zodResolver } from "@hookform/resolvers/zod"; | ||
| import { RiArrowRightLine } from "@remixicon/react"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.