-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: email and password login feature #260
Conversation
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a build error, details on this thread
https://discord.com/channels/1193628549756747776/1203029858385399878/1231472102633377863
Thanks for the review. I will fix that quickly. |
I believe we need to update the flow for inviting users as we switch to a credential provider. The current invite flow is based on a magic link provider, so passwords might not be included in it. 🤔 |
I think we can utilize password reset flow for invitation as well. @anikdhabal lets create a different issue for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this PR @anikdhabal . I have created few issues to improve/fix some flows.
Merging this for now, so above issues are unblocked.
fixes #204