Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Audit trpc calls #440

Merged
merged 46 commits into from
Jul 20, 2024
Merged

feat: Audit trpc calls #440

merged 46 commits into from
Jul 20, 2024

Conversation

VK-RED
Copy link
Contributor

@VK-RED VK-RED commented Jul 13, 2024

resolves #275

Copy link

github-actions bot commented Jul 13, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@VK-RED VK-RED marked this pull request as ready for review July 17, 2024 06:43
"bucket.created",

"stripe.session-created",
"stripe.billingPortalSession-created",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stripe setup is not a company specific setup, so lets remove all stripe audits.

"role.updated",
"role.deleted",

"template.field-created",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to template.updated , details will be on summary


"passkey.created",
"passkey.authOptions-created",
"passkey.registrationOptions-created",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change both authOptions... and registration... to passkey.updated, details will be on summary

const { user } = session;
await Audit.create(
{
action: "company.lastAccessed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, let's remove it.


"company.created",
"company.lastAccessed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, lets remove lastAccessed audit

@@ -51,6 +55,37 @@ export const AuditSchema = z.object({

"update.public-status",
"update.private-status",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are on this, can you please change these two status with update.updated, details will be on summary

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR @VK-RED , it looks good overall . Please make these recommended changes.

@VK-RED
Copy link
Contributor Author

VK-RED commented Jul 17, 2024

Will update it soon @dahal !!

@VK-RED VK-RED requested a review from dahal July 17, 2024 13:32
@dahal dahal merged commit 0931160 into captableinc:main Jul 20, 2024
2 checks passed
@VK-RED VK-RED deleted the feat/add-Audit.create branch July 26, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go through all the TRPC calls and add missing Audit.create
2 participants