-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Audit trpc calls #440
Conversation
Thank you for following the naming conventions for pull request titles! 🙏 |
src/server/audit/schema.ts
Outdated
"bucket.created", | ||
|
||
"stripe.session-created", | ||
"stripe.billingPortalSession-created", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stripe setup is not a company specific setup, so lets remove all stripe audits.
src/server/audit/schema.ts
Outdated
"role.updated", | ||
"role.deleted", | ||
|
||
"template.field-created", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to template.updated
, details will be on summary
src/server/audit/schema.ts
Outdated
|
||
"passkey.created", | ||
"passkey.authOptions-created", | ||
"passkey.registrationOptions-created", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change both authOptions... and registration...
to passkey.updated
, details will be on summary
const { user } = session; | ||
await Audit.create( | ||
{ | ||
action: "company.lastAccessed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this, let's remove it.
src/server/audit/schema.ts
Outdated
|
||
"company.created", | ||
"company.lastAccessed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this, lets remove lastAccessed
audit
src/server/audit/schema.ts
Outdated
@@ -51,6 +55,37 @@ export const AuditSchema = z.object({ | |||
|
|||
"update.public-status", | |||
"update.private-status", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are on this, can you please change these two status with update.updated
, details will be on summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR @VK-RED , it looks good overall . Please make these recommended changes.
Will update it soon @dahal !! |
resolves #275