Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sign template status #450

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

VK-RED
Copy link
Contributor

@VK-RED VK-RED commented Jul 18, 2024

Resolves #441

Copy link

github-actions bot commented Jul 18, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VK-RED thanks for working on this issue. I just went through the PR, however there are few things we need to add, may be i should have been more clear on the issue, my apologies.

  • We also need to update the status of the template based on different action

  • When you are esign template page, page where you setup the fields and stuff, the status will be on Draft

  • When you are done configuring and send it for signature, the status will be Sent

  • If multiple parties need to sign, and atleast one has signed but not everybody signed yet, the status should be updated to waiting
    When all parties sign, it should be complete

  • On the eSign table, we also need to introduce cancel option, when clicked it should update the status to cancelled

  • If the status is cancelled, we should show the error message, if any esign party goes to the link to sign the document with a message, something like

title: Cancelled
subtitle: This document signing has been cancelled., we can use EmptyState with error = {true} component for this as well.

@dahal dahal self-assigned this Jul 21, 2024
@dahal dahal merged commit 99eb85f into captableinc:main Jul 25, 2024
2 checks passed
@VK-RED VK-RED deleted the feat/eSign-template-status branch July 26, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more eSign template status
2 participants