Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track events with audit logs #92

Merged
merged 18 commits into from
Feb 6, 2024
Merged

Conversation

G3root
Copy link
Collaborator

@G3root G3root commented Feb 3, 2024

fixes #90

@G3root G3root linked an issue Feb 3, 2024 that may be closed by this pull request
@G3root G3root marked this pull request as draft February 3, 2024 09:34
@G3root G3root marked this pull request as ready for review February 4, 2024 09:11
@G3root
Copy link
Collaborator Author

G3root commented Feb 4, 2024

known issues

@G3root G3root requested a review from dahal February 4, 2024 09:14
@dahal
Copy link
Contributor

dahal commented Feb 5, 2024

known issues

@G3root I don't think #79 will fix it. Lets create an issue for this.

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great @G3root , I have left a comment, else its good to go.

"remove",
"revoke-invite",
"deactivate",
"activate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep these events/actions consistent, lets go with signed-up, invited, re-invited, accepted.

Note: these events has already occurred, it only makes sense to stick with past tense.

@G3root G3root requested a review from dahal February 5, 2024 11:06
@dahal dahal merged commit 2727676 into main Feb 6, 2024
1 check failed
@dahal dahal deleted the 90-start-tracking-auditsevents branch February 6, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start tracking audits/events
2 participants