Support for root field tags (#162) #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support for root field tags
Right now the mechanism for defining root fields is just too cumbersome. It requires defining a type `type Query = unknown` is nonsensicle _and_ is part of the very first hello world.
Additionally, it requires defining functions with unused initial arguments:
```typescript
/** @gqlField */
export function greeting(_: Query): string {
return "Hello";
}
```
This is confusing and nonsensicle, but also prevents these fields being reused for non-GraphQL use cases which goes aginst the goals of Grats, which includes lettting people expose thier _existing_ TypeScript code.
This PR adds three new tags to let you define Query/Mutation/Subscription fields without needing to explictly define or reference these types.
[ghstack-poisoned]
* Update on "Support for root field tags"
Right now the mechanism for defining root fields is just too cumbersome. It requires defining a type `type Query = unknown` is nonsensicle _and_ is part of the very first hello world.
Additionally, it requires defining functions with unused initial arguments:
```typescript
/** gqlField */
export function greeting(_: Query): string {
return "Hello";
}
```
This is confusing and nonsensicle, but also prevents these fields being reused for non-GraphQL use cases which goes aginst the goals of Grats, which includes lettting people expose thier _existing_ TypeScript code.
This PR adds three new tags to let you define Query/Mutation/Subscription fields without needing to explictly define or reference these types.
[ghstack-poisoned]
* Update on "Support for root field tags"
Right now the mechanism for defining root fields is just too cumbersome. It requires defining a type `type Query = unknown` is nonsensicle _and_ is part of the very first hello world.
Additionally, it requires defining functions with unused initial arguments:
```typescript
/** gqlField */
export function greeting(_: Query): string {
return "Hello";
}
```
This is confusing and nonsensicle, but also prevents these fields being reused for non-GraphQL use cases which goes against the goals of Grats, which includes lettting people expose their _existing_ TypeScript code.
Now such fields can be defined using:
```typescript
/** gqlQueryField */
export function greeting(): string {
return "Hello";
}
```
This PR adds three new tags to let you define Query/Mutation/Subscription fields without needing to explictly define or reference these types.
[ghstack-poisoned]
✅ Deploy Preview for grats ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the mechanism for defining root fields is just too cumbersome. It requires defining a type
type Query = unknownis nonsensicle and is part of the very first hello world.Additionally, it requires defining functions with unused initial arguments:
This is confusing and nonsensicle, but also prevents these fields being reused for non-GraphQL use cases which goes against the goals of Grats, which includes letting people expose their existing TypeScript code.
Now such fields can be defined using:
This PR adds three new tags to let you define Query/Mutation/Subscription fields without needing to explicitly define or reference these types.