Merge pull request #84 from khorshuheng/missing-import

Fix missing imports
caraml-dev · Jan 9, 2023 · 995722b · 995722b
2 parents e0d1692 + f616e77
commit 995722b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/caraml-store-python/feast/client.py b/caraml-store-python/feast/client.py
@@ -182,8 +182,10 @@ def list_feature_tables(
 
         # Get latest feature tables from Feast Core
         feature_table_protos = self._core_service.ListFeatureTables(
-            filter=ListFeatureTablesRequest.Filter(
-                project=project, labels=labels or dict()
+            ListFeatureTablesRequest(
+                filter=ListFeatureTablesRequest.Filter(
+                    project=project, labels=labels or dict()
+                )
             )
         )
 

diff --git a/caraml-store-python/feast/data_source.py b/caraml-store-python/feast/data_source.py
@@ -2,7 +2,7 @@
 from typing import Dict, Optional
 
 from feast.core.DataSource_pb2 import DataSource as DataSourceProto
-from feast.data_format import FileFormat
+from feast.data_format import FileFormat, StreamFormat
 
 
 class SourceType(enum.Enum):
@@ -251,6 +251,22 @@ def from_proto(data_source):
                 created_timestamp_column=data_source.created_timestamp_column,
                 date_partition_column=data_source.date_partition_column,
             )
+        elif (
+            data_source.kafka_options.bootstrap_servers
+            and data_source.kafka_options.topic
+            and data_source.kafka_options.message_format
+        ):
+            data_source_obj = KafkaSource(
+                field_mapping=data_source.field_mapping,
+                bootstrap_servers=data_source.kafka_options.bootstrap_servers,
+                message_format=StreamFormat.from_proto(
+                    data_source.kafka_options.message_format
+                ),
+                topic=data_source.kafka_options.topic,
+                event_timestamp_column=data_source.event_timestamp_column,
+                created_timestamp_column=data_source.created_timestamp_column,
+                date_partition_column=data_source.date_partition_column,
+            )
         else:
             raise ValueError("Could not identify the source type being added")
 

diff --git a/caraml-store-python/feast/loaders/__init__.py b/caraml-store-python/feast/loaders/__init__.py