Merge pull request #87 from khorshuheng/revert-bq-retrieval

Revert BQ based historical retrieval
caraml-dev · Feb 8, 2023 · a1c40a7 · a1c40a7
2 parents e464ec0 + d4bae6e
commit a1c40a7
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/caraml-store-pyspark/scripts/historical_feature_retrieval_job.py b/caraml-store-pyspark/scripts/historical_feature_retrieval_job.py
@@ -896,14 +896,9 @@ def start_job(
         source_from_dict(dct) for dct in feature_tables_sources_conf
     ]
     entity_source = source_from_dict(entity_source_conf)
-    if isinstance(entity_source, BigQuerySource) and all([isinstance(source, BigQuerySource) for source in
-                                                          feature_tables_sources]):
-        feature_tables_sources = [cast(BigQuerySource, source) for source in feature_tables_sources]
-        result = retrieve_historical_features_bq(spark, entity_source, feature_tables_sources, feature_tables)
-    else:
-        result = retrieve_historical_features(
-            spark, entity_source, feature_tables_sources, feature_tables
-        )
+    result = retrieve_historical_features(
+        spark, entity_source, feature_tables_sources, feature_tables
+    )
 
     destination = FileDestination(**destination_conf)