Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key retrieval metrics #94

Merged
merged 1 commit into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,18 @@ private List<Counter> newEntityCounters(GetOnlineFeaturesRequest featureRequest)
.toList();
}

private Counter newKeyRetrievalCounter(String project) {
return Counter.builder("caraml_serving_key_retrieval_count")
.tag("project", project)
.register(registry);
}

@Override
public void onRequestReceived(ReqT requestMessage) {
if (requestMessage instanceof GetOnlineFeaturesRequest featureRequest) {
String project = featureRequest.getProject();
newServingRequestCounter(project).increment();
newKeyRetrievalCounter(project).increment(featureRequest.getEntityRowsCount());
newEntityCounters(featureRequest)
.forEach(counter -> counter.increment(featureRequest.getEntityRowsCount()));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public StoreService(OnlineRetriever retriever, FeatureSpecService specService) {
}

public GetOnlineFeaturesResponseV2 getOnlineFeaturesV2(GetOnlineFeaturesRequest request) {
if(request.getEntityRowsList().isEmpty()) {
if (request.getEntityRowsList().isEmpty()) {
throw new IllegalArgumentException("Entity rows cannot be empty");
}

Expand All @@ -77,7 +77,7 @@ public GetOnlineFeaturesResponseV2 getOnlineFeaturesV2(GetOnlineFeaturesRequest
}

public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequest request) {
if(request.getEntityRowsList().isEmpty()) {
if (request.getEntityRowsList().isEmpty()) {
throw new IllegalArgumentException("Entity rows cannot be empty");
}

Expand Down