Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc(caraml-ai): Set up CaraML AI mockup #109

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Jul 19, 2024

Context

This PR introduces a new page CaraML AI which is meant to be a temporary placeholder to contain an embedded streamlit app (which is intended to make calls to certain LLM models). This page is currently only used as a proof-of-concept as its implementation is intentionally kept simple for that purpose.

The changes in this PR can be logically divided into 2 parts:

  1. Addition of a new application CaraML AI with the corresponding endpoint /caraml-ai
    • This includes related changes to accommodate the IsProjectAgnostic config flag - this flag ensures that UI redirects to this application are made without the /project/{project_id} extension, since this application is meant to be project-agnostic)
  2. A temporary UI page served by the MLP UI at the caraml-ai endpoint, containing an embedded streamlit app
    • This includes the introduction of an additional CaramlAIStreamlitHomepage config on the MLP API server for specifying the streamlit endpoint
    • This page is only meant to be used temporarily until a more permanent UI can be developed (and may even be hosted separately by a separate service at the same \caraml-ai endpoint)

Screenshot 2024-07-19 at 16 41 32

@deadlycoconuts deadlycoconuts self-assigned this Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (a234b6b) to head (bdf87e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          47       47           
  Lines        2443     2443           
=======================================
  Hits         1396     1396           
  Misses        851      851           
  Partials      196      196           
Flag Coverage Δ
api-test 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jul 19, 2024
@deadlycoconuts deadlycoconuts requested a review from leonlnj July 19, 2024 11:15
@deadlycoconuts deadlycoconuts marked this pull request as ready for review July 19, 2024 11:15
@leonlnj
Copy link

leonlnj commented Jul 22, 2024

LGTM, only issue is project changing while at the CaraML AI page might be crash

@deadlycoconuts
Copy link
Contributor Author

Thanks for catching that! I just fixed it by updating the navigation link when a project is selected; when a user selects a new project on a project-agnostic app, the user will be redirected to the MLP project landing page for that selected project.

@deadlycoconuts deadlycoconuts merged commit 09c363a into caraml-dev:main Jul 22, 2024
10 checks passed
@deadlycoconuts deadlycoconuts deleted the set_up_streamlit_poc branch July 22, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants