fix: init webhook validation check #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 56.39% 56.75% +0.35%
==========================================
Files 48 48
Lines 2477 2479 +2
==========================================
+ Hits 1397 1407 +10
+ Misses 884 878 -6
+ Partials 196 194 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
|
Thank you for the review @tiopramayudi! |
bthari
added a commit
to caraml-dev/merlin
that referenced
this pull request
Oct 15, 2024
# Description Previously on #601 I added webhook for model version endpoint related event, and in here the event will be expanded into a model, model endpoint, model version related event, as we also want to have an action (from other service) to be triggered if these events happen. # Modifications <!-- Summarize the key code changes. --> - created another package for webhook interface - add event for: - model created - model endpoint created/updated/deleted - model version created/updated/deleted - change previous event name of `on-model-version-*` to `on-version-endpoint-*` # Tests # Checklist - [x] Added PR label - [x] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Notes for Reviewer The version of MLP used here has a validation bug (which is updated on [MLP#117](caraml-dev/mlp#117)). The code could still work with workaround (e.g. set `FinalResponse: true` in one async webhook if user use _all_ async webhook, but it will be confusing for user since async webhook response is expected to not be used anywhere), ~~so preferably to merge this PR after updating the MLP version as dependencies.~~ (MLP version will be updated with the s3 PR) # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note add webhook event call if there's changes on model, model endpoint, model version ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When trying to initiate all async webhook, the webhook validation check throw an error that "at least 1 sync client must have finalResponse set to true". On the other hands, if trying to setup multiple sync & async client, where only async client has
finalResponse=true, the validation will passChanges
useIdx > idxwill never be true/reached, because ifuseIdx > idxthen this must have been true then throw an error