Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp MLP UI Sidebar Menu #15

Merged
merged 9 commits into from
Apr 9, 2021
Merged

Revamp MLP UI Sidebar Menu #15

merged 9 commits into from
Apr 9, 2021

Conversation

tiopramayudi
Copy link
Collaborator

@tiopramayudi tiopramayudi commented Mar 31, 2021 •
edited
Loading

Change the looks and experience of sidebar menu. In this PR only UI files that modified. Below are attached screenshots

Screen Shot 2021-03-31 at 11 01 14

When merlin integrate with new sidebar menu, merlin app is highlighted because currently active app is merlin
Screen Shot 2021-03-31 at 11 08 54

Sidebar menu will be moved to Header, hence to use this new sidebar menu, user just need to specify the header

<Header
            appIcon="graphApp"
            docLinks={config.DOC_LINKS}
 />

where docLinks is list of documentation that relevant to be shown which has format like:

[
   {
      "href":"https://github.com/gojek/merlin/blob/main/docs/getting-started/README.md",
      "label":"Merlin User Guide"
   },
   {
      "href":"https://github.com/gojek/turing",
      "label":"Turing User Guide"
   },
   {
      "href":"https://docs.feast.dev/user-guide/overview",
      "label":"Feast User Guide"
   }
]

pradithya
pradithya reviewed Mar 31, 2021
View reviewed changes
ui/packages/lib/src/components/nav_drawer/NavDrawer.js Outdated
@@ -52,29 +39,123 @@ export const NavDrawer = ({ homeUrl = "/", appLinks }) => {
}
];

const docLinks = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be configurable and I don't think we should include link to gojek internal documentations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on making it configurable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 just realised this. Should we make it configurable from db?

pradithya
pradithya reviewed Mar 31, 2021
View reviewed changes
ui/packages/app/src/PrivateLayout.js Outdated
{({ projectId }) => projectId && <NavDrawer />}
</CurrentProjectContext.Consumer>
<Component {...props} />
<div style={{ paddingTop: "49px" }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not do in-line style?

pradithya
pradithya reviewed Mar 31, 2021
View reviewed changes
ui/packages/lib/src/components/header/Header.js Outdated
}
aria-label="Machine Learning Platform"
/>
<EuiText style={{ padding: "10px" }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove in-line style?

pradithya
pradithya reviewed Mar 31, 2021
View reviewed changes
ui/packages/lib/src/components/nav_drawer/NavDrawer.js Outdated
showCloseButton={false}
isDocked={navIsDocked}
showButtonIfDocked={true}
style={{ top: "49px", height: "calc(100% - 49px)", width: "262px" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove in-line stype?

ariefrahmansyah
ariefrahmansyah reviewed Mar 31, 2021
View reviewed changes
ui/packages/lib/src/components/nav_drawer/NavDrawer.js Outdated
</EuiFlexItem>

<EuiHorizontalRule margin="none" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this rule after the Project Setting button. Similar to the previous sidebar:
image

@romanwozniak
Copy link
Contributor

I'm not sure if it's a good idea to have component-level user manuals be shown at once, independently from what product is currently in-use.

@romanwozniak
Copy link
Contributor

Since we already touching sidebar, I think it makes sense to make product menu items (e.g. 'Merlin', 'Feast') to be expandable and have quick-access links to specific resources of a relevant component under them.

Somethin like:

v Merlin
– Models
– Endpoints
– Batch Jobs
v Feast
– Entities
– Feature Sets
...

pradithya
pradithya approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@pradithya pradithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you explicitly mention in the MR description how the new NavDrawer behave especially in term of how respective product can add their docs link.

@tiopramayudi
Copy link
Collaborator Author

Since we already touching sidebar, I think it makes sense to make product menu items (e.g. 'Merlin', 'Feast') to be expandable and have quick-access links to specific resources of a relevant component under them.

Somethin like:

v Merlin
– Models
– Endpoints
– Batch Jobs
v Feast
– Entities
– Feature Sets
...

I think we can implement your suggestion in the next milestone

@tiopramayudi tiopramayudi merged commit eb9570c into main Apr 9, 2021
@tiopramayudi tiopramayudi deleted the sidebar-menu branch April 9, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariefrahmansyah ariefrahmansyah ariefrahmansyah left review comments

@pradithya pradithya pradithya approved these changes

@romanwozniak romanwozniak Awaiting requested review from romanwozniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiopramayudi @romanwozniak @pradithya @ariefrahmansyah