Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adding context and merge artifact service creation into mlflow #80

Merged
merged 7 commits into from
Apr 10, 2023
Merged

refactor: adding context and merge artifact service creation into mlflow #80

merged 7 commits into from
Apr 10, 2023

Conversation

zenovore
Copy link
Collaborator

@zenovore zenovore commented Apr 6, 2023 •
edited
Loading

  • Refactoring Mlflow delete package, handling creation of artifactService inside mlflowService
  • Passing Context for each api call, context passed from turing/merlin

@zenovore zenovore marked this pull request as ready for review April 6, 2023 11:37
deadlycoconuts
deadlycoconuts requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for getting the new changes out so quickly! Just left some tiny comments but they mostly look good!

api/pkg/artifact/artifact.go Outdated Show resolved Hide resolved
api/pkg/artifact/artifact.go Outdated Show resolved Hide resolved
api/pkg/artifact/artifact.go Outdated Show resolved Hide resolved
api/pkg/client/mlflow/mlflow.go Outdated Show resolved Hide resolved
api/pkg/client/mlflow/mlflow_test.go Outdated Show resolved Hide resolved
@zenovore zenovore requested a review from deadlycoconuts April 10, 2023 06:32
deadlycoconuts
deadlycoconuts approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring these stuff! Hopefully we'll get them to work in Turing and Merlin! 🚀

@deadlycoconuts deadlycoconuts merged commit 3117e9e into caraml-dev:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@krithika369 krithika369 Awaiting requested review from krithika369

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenovore @deadlycoconuts