bugfix: existing role permissions should not be removed during update #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
fix-role-permission-update
branch
from
1343012 to
2fff874
Compare
khorshuheng
force-pushed
the
fix-role-permission-update
branch
from
2fff874 to
849653f
Compare
krithika369
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, existing permissions of a role is removed before the new ones are inserted. This behaviour is fine for project administrator and reader roles, but problematic for mlp administrator roles. As present, if someone update or create a new project, the mlp administrator role will gain the permissions of the new/updated project, but lost every other access.
After this fix, existing permissions will not be removed during an authorization update. The method has also been renamed for better clarity of the intention.