Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-index): fix horizontal scrolling on component index page #1883

Merged
merged 9 commits into from
Oct 27, 2020
Merged

Conversation

aledavila
Copy link
Contributor

Closes #1628

Fixes the jumping around of the index page on mobile. The issue came from the tags in the component view adding some random extra space.

Changelog

Changed

  • changed the tags in the footers to absolute positioning.

Check mobile component index page

@aledavila aledavila requested a review from a team as a code owner October 8, 2020 20:07
@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/nkosxkb46
✅ Preview: https://carbondesignsystem-git-1628-index.carbon-design-system.vercel.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@alisonjoseph alisonjoseph requested review from a team and jeanservaas and removed request for a team October 13, 2020 23:10
@aledavila
Copy link
Contributor Author

I removed the file and it doesnt seem to mess anythign up. Mind giving it one more look :) @joshblack

@kodiakhq kodiakhq bot merged commit 99dfa47 into carbon-design-system:master Oct 27, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
carbon-design-system#1883)

* fix(component-index): fix horizontal scrolling on component index page

* chore: remove empty styles page

Co-authored-by: Andrea N. Cardona <[email protected]>
Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
carbon-design-system#1883)

* fix(component-index): fix horizontal scrolling on component index page

* chore: remove empty styles page

Co-authored-by: Andrea N. Cardona <[email protected]>
Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community assets —> Component index: Page should be locked in mobile
5 participants