-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon platform update #3380
Carbon platform update #3380
Conversation
* update: usage content * update: usage images * update: style content * update: image * update: image * fix: run format Co-authored-by: Josefina Mancilla <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…#3087) * chore(deps): bump parse-url from 6.0.0 to 6.0.5 Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.5. - [Release notes](https://github.com/IonicaBizau/parse-url/releases) - [Commits](IonicaBizau/parse-url@6.0.0...6.0.5) --- updated-dependencies: - dependency-name: parse-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(format): run yarn format Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…ptions (carbon-design-system#3093) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* docs(date-picker): gower review * Update date-format-placement.png * add type styles * Update style.mdx * Apply suggestions from design review Co-authored-by: Lauren Rice <[email protected]> * update calendar images Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: jnm2377 <[email protected]>
Co-authored-by: kodiakhq <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* accessibility content for overflow menu text and images for accessibility guidance * fix: run format Co-authored-by: Josefina Mancilla <[email protected]> Co-authored-by: Josefina Mancilla <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…-system#3095) * docs(migration): mention upgrade cli in developer docs * Update develop.mdx Co-authored-by: D.A. Kahn <[email protected]>
* docs(tree-view): new component * remove-tooltip-content * Update usage.mdx * formate updates * Update usage.mdx * add-style-tab-content * remove line breaks * fixed format bug * fixed bugs * image size test * Update code.mdx * update-images * Update usage.mdx * Apply suggestions from design review Co-authored-by: Lauren Rice <[email protected]> * Update src/pages/components/tree-view/style.mdx Co-authored-by: Lauren Rice <[email protected]> * updated-overview-image * fix: format and add to nav * Update code.mdx Co-authored-by: Lauren Rice <[email protected]> Co-authored-by: Josefina Mancilla <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Update step-1.mdx Hi, it took me quiet some time to run the step-1 part of the tutorial, the section about icons namely. After digging into documentation of `carbon-component-angular` module I was able to make the icons working properly. Therefore you would like to propose couple changes in this part of the step-1 documentation. * Update step-1.mdx Forgot to mention the registration of the icon/s so adding that part as well. * Update src/pages/developing/angular-tutorial/step-1.mdx ok, thx Co-authored-by: Akshat Patel <[email protected]> * Update src/pages/developing/angular-tutorial/step-1.mdx ok thx Co-authored-by: Akshat Patel <[email protected]> * Update src/pages/developing/angular-tutorial/step-1.mdx ok thx Co-authored-by: Akshat Patel <[email protected]> Co-authored-by: Akshat Patel <[email protected]> Co-authored-by: D.A. Kahn <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ibmButton attribute (directive) needs to value. According the page preview at the top I add `primary`. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
The --lint-fix parameter can't be used anymore for generating angular component. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix: remove ibm z pictograms * chore: format
* feat(tutorial): add initial faqs * docs(tutorial): add additional FAQ answers Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* dividing file names for code snippets There are 2 files (`src/app/home/home.module.ts` and `src/app/home/landing-page/landing-page.component.spec.ts`) mentioned above 2 code snippets that is explaining how to import carbon modules. But One code snippet is for app.module.ts and second is for landing-page.component.spec.ts and it unnecessary to mentioned both files above both code snippets. This is on 2 spots `First row` and `Second row` section. * division of file names above code snippets Found addition 2 spots in `Repo page` section Co-authored-by: D.A. Kahn <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Update overview.mdx * chore(Overview): ran yarn:format
Co-authored-by: kodiakhq <[email protected]>
…arbon-design-system#3117) * fix(2x-grid): fix link typo * style(404): update 404 styles * chore(format): run yarn format Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* updating accessibility content and adding image * Update accessibility.mdx removed second image placeholder for now * Update accessibility.mdx rewrote introduction * Update accessibility.mdx rewrote heading * Update accessibility.mdx Reworded design guidance * Update accessibility.mdx updated link text * Update accessibility.mdx slight rewording * added two images and updated content * chore(loading): format PR * Update loading-accessibility-3.png added Lauren's image Co-authored-by: dakahn <[email protected]>
* fix(docs): replace check emoji with CheckmarkOutline component * fix(docs): remove unused import
* Update color-tokens.js * run yarn format * update-text-on-color-disabled * add token name to values * Update color-tokens.js * remove token name in value * update opacity formating * reverting to previous format test * reset formating again Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* [docs] text-input: usage-update * added-rest-of-content * content-QA * update-img-link * content-qa-2 * Apply suggestions from design review Co-authored-by: Lauren Rice <[email protected]> * image and content updates * Update usage.mdx Co-authored-by: Lauren Rice <[email protected]>
* Notification for Tile * Update src/pages/components/tile/usage.mdx Co-authored-by: Anna Gonzales <[email protected]> Co-authored-by: Anna Gonzales <[email protected]> Co-authored-by: Anna Gonzales <[email protected]>
Co-authored-by: kodiakhq <[email protected]> Co-authored-by: Josefina Mancilla <[email protected]>
Co-authored-by: tay1orjones <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* update colors on Status indicators * update colors 2 * update green 40 * update icon colors * fix(color): update status-success to new values * update images from Jeannie --------- Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Francine Lucca <[email protected]>
Co-authored-by: aledavila <[email protected]>
Co-authored-by: kodiakhq <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francinelucca vercel is failing :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but I'm not sure what's up with Vercel. None of the errors seem to point to files you changed. Does this build and run locally for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed the files changed and it looks good!
Could also just need a redeploy? |
@tay1orjones @andreancardona yeah vercel failure is expected, because of the changes we've done to the code (previously) on |
Platform Sync, pulling in new content from main into carbon-platform branch