Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update progress indicator style tab #3996

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[Docs] Update progress indicator style tab #3996

merged 2 commits into from
Apr 3, 2024

Conversation

aubrey-oneal
Copy link
Member

@aubrey-oneal aubrey-oneal commented Apr 2, 2024 •
edited
Loading

Closes #3465

This PR updates the style tab so that the names of elements match with the usage tab. It also applies the style template.

Changelog

New

  • Anchor links
  • Feedback section

Changed

  • Progress indicator element names
  • Updated image
  • Updated body copy and image descriptions

@aubrey-oneal aubrey-oneal requested review from a team as code owners April 2, 2024 20:06
@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 5:45pm

aagonzales
aagonzales approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

laurenmrice
laurenmrice approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alisonjoseph alisonjoseph enabled auto-merge (squash) April 3, 2024 14:16
@alisonjoseph alisonjoseph merged commit 4a133f7 into carbon-design-system:main Apr 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aagonzales aagonzales aagonzales approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@guidari guidari guidari approved these changes

@benjamin-kurien benjamin-kurien Awaiting requested review from benjamin-kurien benjamin-kurien is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress indicator: Style tab
5 participants
@aubrey-oneal @alisonjoseph @aagonzales @laurenmrice @guidari