Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notification/usage.mdx with content-focused edits #4434

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lesnider
Copy link
Contributor

Related to #4165

Content edits to Notification component topic

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:04pm

@alina-jacob
Copy link
Member

Hi @alisonjoseph, @guidari, could you please help with the deploy preview for this PR, thanks!

@lesnider
Copy link
Contributor Author

@laurenmrice Hi, Lauren. Can you indicate the status of the PR related to this issue, please? It seems like there's movement, but the changes haven't been implemented yet.

@laurenmrice
Copy link
Member

@lesnider You can view your changes by clicking on this link in this PR. Looks like your changes have been made there.
Screenshot 2025-01-28 at 2 24 53 PM

@lesnider
Copy link
Contributor Author

@laurenmrice Thanks, Lauren. Do you know when they will go live? I am not seeing them in the guidelines yet.

@laurenmrice
Copy link
Member

@lesnider Once this PR merges the changes will go live on the real website. We need to get an approved review first on this PR by a Carbon developer and a Carbon designer before we can merge it. I have put this on my next sprint (starting Thursday), to give this a review from a design side.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good @lesnider ⭐️, thank you for taking the time to make our Notification documentation better! Below I just mentioned a couple comments and typo fixes:

src/pages/components/notification/usage.mdx Show resolved Hide resolved
src/pages/components/notification/usage.mdx Show resolved Hide resolved
src/pages/components/notification/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/notification/usage.mdx Outdated Show resolved Hide resolved
@laurenmrice laurenmrice removed the request for review from kiran-ravindra-ibm January 31, 2025 16:45
@lesnider
Copy link
Contributor Author

@laurenmrice I accommodated all but one change, as noted above. I couldn't assign you as a reviewer to the next PR: lesnider#1.

@alina-jacob
Copy link
Member

@laurenmrice I accommodated all but one change, as noted above. I couldn't assign you as a reviewer to the next PR: lesnider#1.

@lesnider, maybe the patch is not reflecting in the right repo
image
image


Suggesting a couple of alternatives:

  • You can make the changes to your existing branch itself instead of creating a patch.
  • You can also click the "commit suggestion" button within github to have it updated directly in the branch file!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants