Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): label table when table container is used #11761

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

joshblack
Copy link
Contributor

Closes #3805

Add support for labeling the <table> element based on the title and description provided to TableContainer.

Changelog

New

  • Add TableContext to be used to share information between table components

Changed

  • Update TableContainer to generate ids for the title and description and pass it through context
  • Update Table to use TableContext and read title and description ids

Removed

Testing / Reviewing

  • Go into storybook examples that use TableContainer and verify that <table> is correctly labeled by the title and description used in Table

@joshblack joshblack requested a review from a team as a code owner July 6, 2022 18:51
@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2474619
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62cd6ddedc805900083495ee
😎 Deploy Preview https://deploy-preview-11761--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2474619
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62cd6dde782ff4000831d218
😎 Deploy Preview https://deploy-preview-11761--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 79b0b17 into carbon-design-system:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants