-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): update types hasIconOnly & kind !== danger #17272
fix(button): update types hasIconOnly & kind !== danger #17272
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17272 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 408 408
Lines 13958 13966 +8
Branches 4333 4336 +3
=======================================
+ Hits 10723 10730 +7
Misses 3062 3062
- Partials 173 174 +1 ☔ View full report in Codecov by Sentry. |
a6f1b23
Hey there! v11.66.0 was just released that references this issue/PR. |
Closes #17036
[warnings visible when setting the wrong kind]
Changelog
Changed
kind
to equalhasIconOnly
?iconButtonKind
:buttonKind
Testing / Reviewing