Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datatable): add padding so search clear button doesn't obstruct text #5145

Merged
merged 11 commits into from
Jan 27, 2020
Merged

fix(datatable): add padding so search clear button doesn't obstruct text #5145

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
073db0b
fix(datatable): add padding so search clear button doesn't obstruct text
tw15egan Jan 22, 2020
a8f0c37
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 22, 2020
097802f
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 22, 2020
9a44177
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 22, 2020
8219f7b
fix(datatable): fix search close focus issue
tw15egan Jan 23, 2020
2db0653
Merge branch 'data-table-style-fixes' of github.com:tw15egan/carbon-c…
tw15egan Jan 23, 2020
daca9b4
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 24, 2020
8085f1b
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 24, 2020
cc22825
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 27, 2020
d97384b
Merge branch 'master' into data-table-style-fixes
tw15egan Jan 27, 2020
5c2a8c2
Merge branch 'master' into data-table-style-fixes
asudoh Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/components/src/components/data-table/_data-table-action.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@
}
}

.#{$prefix}--toolbar-search-container-expandable
.#{$prefix}--search
.#{$prefix}--search-close:focus::before {
background-color: $focus;
}

//-------------------------------------------------
//ACTIVE SEARCH - DEFAULT TOOLBAR
//-------------------------------------------------
Expand All @@ -141,7 +147,7 @@
.#{$prefix}--toolbar-search-container-active
.#{$prefix}--search
.#{$prefix}--search-input {
padding-left: $spacing-09;
padding: 0 $spacing-09;
visibility: inherit;
}

Expand Down Expand Up @@ -197,6 +203,11 @@
background-color: transparent;
}

.#{$prefix}--toolbar-search-container-persistent
.#{$prefix}--search-close::before {
display: none;
}

//-------------------------------------------------
//TOOLBAR BUTTONS
//-------------------------------------------------
Expand Down Expand Up @@ -296,7 +307,7 @@
.#{$prefix}--search
.#{$prefix}--search-input {
height: $layout-04;
padding-left: $spacing-09;
padding: 0 $spacing-09;
border: none;
}

Expand Down Expand Up @@ -513,7 +524,7 @@
.#{$prefix}--toolbar-search-container-expandable
.#{$prefix}--search
.#{$prefix}--search-input {
padding-left: $spacing-xl;
padding: 0 $spacing-09;
}

//active
Expand Down