feat(FileUploaderDropContainer): validate filetypes from OS file picker #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit e2c7c1c |
|
Deploy preview for carbon-components-react ready! Built with commit e2c7c1c https://deploy-preview-6868--carbon-components-react.netlify.app |
tw15egan
approved these changes
Sep 21, 2020
aledavila
approved these changes
Sep 22, 2020
aledavila
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
emyarod
deleted the
6864-validate-filetypes-in-native-os-file-selector
branch
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6864
This PR validates file types when using the native OS file picker for the scenario where the user deliberate selects the option to choose all file types rather than remaining on the default OS file picker behavior of only allowing supported file types (see screenshot in ticket thread for more context). This PR also updates the demos to show examples of file type validation
Changelog
New
Changed
Testing / Reviewing
Using the native OS file picker, select the option to pick all file types (rather than keeping the default option of only allowing supported file types) and select an invalid file. The demo should mark the file as invalid