You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some errors, such as missing or additional whitespace next to an operator, are recovered by the compiler. In this case, the compiler outputs a diagnostic, but no parse nodes are marked as having an error, and so the compilation succeeds.
What did you do, or what's a simple way to reproduce the bug?
Those tests should only pass with a filename (or split filename) starting with fail_. We need some way to indicate an error in the parse output (like I believe exists for the lex output) even when there are no nodes with an error in the output parse tree.
What actually happened?
Those files have diagnostics with a CHECK:STDERR prefix, but the parse stage succeeds.
The text was updated successfully, but these errors were encountered:
There are a few problems here, notably that pattern matching doesn't correctly diagnose issues. Since this is a bit more nuanced, I don't think it's a good first issue. I'll just take care of it.
Description of the bug:
Some errors, such as missing or additional whitespace next to an operator, are recovered by the compiler. In this case, the compiler outputs a diagnostic, but no parse nodes are marked as having an error, and so the compilation succeeds.
What did you do, or what's a simple way to reproduce the bug?
This problem can be seen in any of the files starting with
recover_
in thetoolchain/parse/testdata/operators/
directory.What did you expect to happen?
Those tests should only pass with a filename (or split filename) starting with
fail_
. We need some way to indicate an error in the parse output (like I believe exists for the lex output) even when there are no nodes with an error in the output parse tree.What actually happened?
Those files have diagnostics with a
CHECK:STDERR
prefix, but the parse stage succeeds.The text was updated successfully, but these errors were encountered: