Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page titles above the license for jekyll compat. #33

Merged
merged 1 commit into from
May 30, 2020
Merged

Move page titles above the license for jekyll compat. #33

merged 1 commit into from
May 30, 2020

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 29, 2020

Also fixes search links to the pages, which is where I noticed this.

@jonmeow jonmeow requested a review from chandlerc May 29, 2020 21:21
@chandlerc
Copy link
Contributor

Seems to have the search change as well?

@jonmeow jonmeow changed the title Move page titles above the license for jekyll compat. Move page titles above the license for jekyll search compat. May 30, 2020
@jonmeow
Copy link
Contributor Author

jonmeow commented May 30, 2020

Added an extra comment -- this rabbit hole is mainly fixing search issues.

@jonmeow jonmeow changed the title Move page titles above the license for jekyll search compat. Move page titles above the license for jekyll compat. May 30, 2020
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense now, LGTM!

@chandlerc
Copy link
Contributor

(I'm going ahead and merging this as it touches a bunch of files to avoid any conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants