Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More focused diagnostic notes for parameters #4420

Merged
merged 1 commit into from
Oct 17, 2024
Merged

More focused diagnostic notes for parameters #4420

merged 1 commit into from
Oct 17, 2024

Conversation

geoffromer
Copy link
Contributor

No description provided.

@geoffromer
Copy link
Contributor Author

This is motivated by some planned refactoring in convert.cpp, but IMO the resulting diagnostics also have better ergonomics, so it's a win/win.

@github-actions github-actions bot requested a review from zygoloid October 17, 2024 04:26
@zygoloid zygoloid added this pull request to the merge queue Oct 17, 2024
Merged via the queue into carbon-language:trunk with commit 5a795db Oct 17, 2024
10 checks passed
@geoffromer geoffromer deleted the param-diagnostics branch October 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffromer @zygoloid