Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test that verifies we prefer a non lexical scope over a lexical scope when doing unqualified name lookup #4591

Merged
merged 18 commits into from
Nov 27, 2024
Merged

Add a test that verifies we prefer a non lexical scope over a lexical scope when doing unqualified name lookup #4591

merged 18 commits into from
Nov 27, 2024

Conversation

bricknerb
Copy link
Contributor

This adds missing test coverage.
See discussion in #4574.

@github-actions github-actions bot requested a review from geoffromer November 26, 2024 06:19
@bricknerb bricknerb mentioned this pull request Nov 26, 2024
Closed
@geoffromer geoffromer requested a review from zygoloid November 26, 2024 18:16
@geoffromer
Copy link
Contributor

Since this came out of #4574, zygoloid might be a better reviewer.

zygoloid
zygoloid approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zygoloid

This comment was marked as resolved.

Sign in to view
@bricknerb
Copy link
Contributor Author

(It looks like you need to rerun autoupdate_testdata -- the test expectations don't quite match the output. Usually this happens because line numbers in the test changed since the previous autoupdate run; sometimes autoupdate takes two runs to stabilize for this reason.)

I hope this passes now.
It definitely passes locally and it seems like I need some stamp here to make it run here.

@bricknerb bricknerb requested a review from zygoloid November 27, 2024 08:59
@geoffromer geoffromer added this pull request to the merge queue Nov 27, 2024
Merged via the queue into carbon-language:trunk with commit e0db74a Nov 27, 2024
8 checks passed
bricknerb added a commit to bricknerb/carbon-lang that referenced this pull request Nov 28, 2024
@bricknerb
Add a test that verifies we prefer unqualified name lookup from a a n…
bf916c9 
…on lexical scope over a lexical scope (carbon-language#4591)

This adds missing test coverage.
See discussion in
carbon-language#4574.
@bricknerb bricknerb changed the title Add a test that verifies we prefer unqualified name lookup from a a non lexical scope over a lexical scope Add a test that verifies we prefer a non lexical scope over a lexical scope when doing unqualified name lookup Dec 2, 2024
@bricknerb bricknerb deleted the unqualified branch December 3, 2024 11:17
danakj pushed a commit to danakj/carbon-lang that referenced this pull request Dec 3, 2024
@bricknerb @danakj
Add a test that verifies we prefer unqualified name lookup from a a n…
6d0e0df 
…on lexical scope over a lexical scope (carbon-language#4591)

This adds missing test coverage.
See discussion in
carbon-language#4574.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer Awaiting requested review from geoffromer

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bricknerb @geoffromer @zygoloid