Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for Carbon Path #4705

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Dec 18, 2024

The extension.ts tries to provide a default, but it's not working the way I expect. So in addition, provide it in properties, which seems to work better.

@github-actions github-actions bot requested a review from chandlerc December 18, 2024 00:48
@github-actions github-actions bot added the utilities Utilities for working with Carbon code: syntax highlighting, editor plugins, etc. label Dec 18, 2024
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jonmeow jonmeow enabled auto-merge December 18, 2024 17:38
@jonmeow jonmeow added this pull request to the merge queue Dec 18, 2024
Merged via the queue into carbon-language:trunk with commit a651ce1 Dec 18, 2024
8 checks passed
@jonmeow jonmeow deleted the vscode-default branch December 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
utilities Utilities for working with Carbon code: syntax highlighting, editor plugins, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants