Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure proposals show up on the jekyll site. #49

Merged
merged 11 commits into from
Jun 4, 2020
Merged

Ensure proposals show up on the jekyll site. #49

merged 11 commits into from
Jun 4, 2020

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Jun 3, 2020 •
edited
Loading

  • Auto-generate the list of proposals for the sidebar.
  • Consolidate to a single sidebar: the multi-sidebar logic seems like unnecessary complexity for us.
  • Cleans up the Makefile to try to get Jekyll refreshing working better.

@jonmeow jonmeow requested a review from chandlerc June 3, 2020 18:03
chandlerc
chandlerc requested changes Jun 4, 2020
View reviewed changes
src/jekyll/sidebar.sh Outdated Show resolved Hide resolved
src/jekyll/sidebar.sh Outdated Show resolved Hide resolved
src/jekyll/sidebar.sh Outdated Show resolved Hide resolved
@jonmeow
Copy link
Contributor Author

jonmeow commented Jun 4, 2020

With this different approach, I'm now thinking maybe I can do away with the manually maintained sidebar entirely. However, I figure I'm best pausing here.

chandlerc
chandlerc approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo, very nice. I like it! =D

Minor tweak below (or feel free to use other wording honestly).

src/jekyll/theme/_data/sidebar.yml Outdated Show resolved Hide resolved
src/jekyll/theme/_includes/sidebar.html Outdated Show resolved Hide resolved
@jonmeow jonmeow merged commit 35d3da0 into carbon-language:master Jun 4, 2020
@jonmeow jonmeow deleted the proposal-jekyll branch June 4, 2020 20:45
This was referenced May 11, 2022
Closed
Closed
@pk19604014 pk19604014 mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc