Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent clang-tidy from changing classof #719

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Prevent clang-tidy from changing classof #719

merged 1 commit into from
Aug 9, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 7, 2021

No description provided.

@jonmeow jonmeow requested a review from geoffromer August 7, 2021 00:15
@jonmeow jonmeow requested a review from a team as a code owner August 7, 2021 00:15
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Aug 7, 2021
chandlerc
chandlerc approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I didn't even know you could exclude stuff this way, really nice!)

@jonmeow jonmeow merged commit deb1981 into carbon-language:trunk Aug 9, 2021
@jonmeow jonmeow deleted the ignore-classof branch August 9, 2021 15:19
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow
Prevent clang-tidy from changing classof (#719)
18e3969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer geoffromer approved these changes

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonmeow @chandlerc @geoffromer