Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds CIP67/68 asset metadata support to asset_info endpoint #239

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Adds CIP67/68 asset metadata support to asset_info endpoint #239

merged 2 commits into from
Oct 9, 2023

Conversation

Scitz0
Copy link
Contributor

@Scitz0 Scitz0 commented Oct 6, 2023 •
edited by rdlrt
Loading

TODO:

[x] - Add schema definition for the new field in response.

@Scitz0 Scitz0 requested a review from rdlrt October 6, 2023 13:21
rdlrt
rdlrt approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a future task we decided could be moving this cip68_metadata field to asset_info_cache to prevent live query against ma_tx_out if it causes performance issue[s]

@rdlrt rdlrt merged commit 4c4da66 into v1.1.0rc Oct 9, 2023
@rdlrt rdlrt deleted the cip68 branch October 9, 2023 07:12
@rdlrt rdlrt mentioned this pull request Oct 17, 2023
Merged
7 tasks
@AstroWa3l AstroWa3l mentioned this pull request Nov 11, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scitz0 @rdlrt