Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0003: Fix Ledger algorithm and one wrong test vector #132

Merged
merged 2 commits into from
Oct 18, 2021
Merged

CIP-0003: Fix Ledger algorithm and one wrong test vector #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b2a9be
CIP-0003: Fix Ledger algorithm and one wrong test vector
benma Sep 23, 2021
85777cb
CIP-0003: link to a reference implementation by Ledger
benma Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CIP-0003/Ledger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
- **Deprecated**: no
- **Summary**: Used by Ledger hardware wallets

Reference implementation by Ledger: [HDEd25519.py](https://github.com/LedgerHQ/orakolo/blob/0b2d5e669ec61df9a824df9fa1a363060116b490/src/python/orakolo/HDEd25519.py)

*Note*: Ledger also allows users to set an additional [passphrase](https://support.ledger.com/hc/en-us/articles/115005214529-Advanced-passphrase-security)

## Code
Expand All @@ -20,7 +22,7 @@ function generateMasterKey(seed, password) {
let cc = HMAC
( hash=SHA256
, key="ed25519 seed"
, message=UTF8NFKD(1) + seed
, message=UTF8NFKD(1) + data
);

let (iL, iR) = hashRepeatedly(data);
Expand Down Expand Up @@ -82,7 +84,7 @@ function tweakBits(data) {

master key
```
1091f9fd9d2febbb74f08798490d5a5727eacb9aa0316c9eeecf1ff2cb5d8e55bc21db1a20a1d2df9260b49090c35476d25ecefa391baf3231e56699974bdd46652f8e7dd4f2a66032ed48bfdffa4327d371432917ad13909af5c47d0d356beb
587c6774357ecbf840d4db6404ff7af016dace0400769751ad2abfc77b9a3844cc71702520ef1a4d1b68b91187787a9b8faab0a9bb6b160de541b6ee62469901fc0beda0975fe4763beabd83b7051a5fd5cbce5b88e82c4bbaca265014e524bd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch. I confirm this from the cardano-wallet's Haskell implementation.

```
</details>

Expand Down