Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove invalid Genesis.shelley.protocolMagicId #332

Merged
merged 1 commit into from
Oct 6, 2020
Merged

fix: remove invalid Genesis.shelley.protocolMagicId #332

merged 1 commit into from
Oct 6, 2020

Conversation

rhyslbw
Copy link
Contributor

@rhyslbw rhyslbw commented Oct 6, 2020

Context

Fixes #327

Proposed Solution

Remove the invalid field, which is already resolved via Genesis.shelley.networkMagic

Important Changes Introduced

  • Re-enables the package test script
  • Removes the single era test scenario, simplifying to a real-world situation.

@rhyslbw
fix: remove invalid Genesis.shelley.protocolMagicId
a73ba1e 
Use Genesis.shelley.networkMagic instead

Fixes #327
@rhyslbw rhyslbw requested a review from issoupadrink October 6, 2020 06:57
@rhyslbw rhyslbw self-assigned this Oct 6, 2020
issoupadrink
issoupadrink approved these changes Oct 6, 2020
View reviewed changes
Copy link

@issoupadrink issoupadrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhyslbw rhyslbw merged commit f7b2426 into master Oct 6, 2020
@rhyslbw rhyslbw deleted the fix/remove-invalid-shelley-genesis-field branch October 6, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issoupadrink issoupadrink issoupadrink approved these changes

Assignees

@rhyslbw rhyslbw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allInfoShelley.graphql example query returns an error about non-nullable field ShelleyGenesis.protocolMagicId.
2 participants
@rhyslbw @issoupadrink