Implement CIP-0129 Governance Identifiers Support in Cardano Wallet #4855
Assignees
Labels
Feature
Mark a PR as adding a new feature, for auto-generated CHANGELOG
Improvement
Mark a PR as an improvement, for auto-generated CHANGELOG
Comments
david-a-clark
added
Improvement
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 13, 2024
<!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
* Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
* Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped
through.
* Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
The PR adds support for
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0129
It adds specified in CIP-0129 prefixes for drep in case of script and
key hash credentials.
The change required to remove `drep_script` HRP that was used preciously
for drep script hashes.
All unit tests, generators therein and golden data was regenerated.
### Comments
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
fix #4855
<!-- Reference the Jira/GitHub issue that this PR relates to, and which
requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
WilliamKingNoel-Bot
pushed a commit
that referenced
this issue
Dec 13, 2024
… work accomplished in this PR. Before you submit, don't forget to: CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> The PR adds support for https://github.com/cardano-foundation/CIPs/tree/master/CIP-0129 It adds specified in CIP-0129 prefixes for drep in case of script and key hash credentials. The change required to remove `drep_script` HRP that was used preciously for drep script hashes. All unit tests, generators therein and golden data was regenerated. ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number fix #4855 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Source commit: 53d41a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem that you wish to solve
CIP-129 has now been approved and merged. Cardano-wallet should be updated to support this CIP to ensure we can handle both types of Drep Id's in the eco-system
Description
As a cardano-wallet user,
I would like cardano-wallet to implement support for CIP-129 Governance Identifiers
to ensure proper handling and representation of DRep, Constitutional Committee (CC) keys, and Governance Actions within cardano-wallet.
Background.
At present cardano-wallet supports CIP-105 , now that CIP-129 has been ratified and merged we need to add additional support for CIP-129
Implementation suggestions
No response
The text was updated successfully, but these errors were encountered: