Add a note under TODO comment

To explain the reason for this to stay. Also improved a NetworkId arg haddock.
cardano-scaling · Jan 3, 2024 · b3fd478 · b3fd478
1 parent fbc9110
commit b3fd478
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/hydra-node/src/Hydra/Chain/CardanoClient.hs b/hydra-node/src/Hydra/Chain/CardanoClient.hs
@@ -68,8 +68,7 @@ data CardanoClient = CardanoClient
 mkCardanoClient :: NetworkId -> SocketPath -> CardanoClient
 mkCardanoClient networkId nodeSocket =
   CardanoClient
-    { queryUTxOByAddress = \addresses -> do
-        queryUTxO networkId nodeSocket QueryTip addresses
+    { queryUTxOByAddress = queryUTxO networkId nodeSocket QueryTip
     , networkId
     }
 

diff --git a/hydra-node/src/Hydra/Chain/Direct.hs b/hydra-node/src/Hydra/Chain/Direct.hs
@@ -316,6 +316,8 @@ chainSyncClient handler wallet startingPoint =
               pure clientStIdle
             BlockInMode _ block ConwayEraInCardanoMode -> do
               -- TODO: uses cardano-api:internal
+              -- NOTE: we should remove this dependency once we have ShelleyBlock available
+              -- on the normal cardano-api library.
               let (ShelleyBlock ShelleyBasedEraConway conwayBlock) = block
               -- XXX: We should not be needing to wrap / unwrap in addition. We
               -- just found those functions to satisfy the types.

diff --git a/hydra-node/src/Hydra/Chain/Direct/ScriptRegistry.hs b/hydra-node/src/Hydra/Chain/Direct/ScriptRegistry.hs
@@ -156,7 +156,8 @@ registryUTxO scriptRegistry =
 --
 -- Can throw at least 'NewScriptRegistryException' on failure.
 queryScriptRegistry ::
-  -- | Current network discriminant
+  -- | cardano-node's network identifier.
+  -- A combination of network discriminant + magic number.
   NetworkId ->
   -- | Filepath to the cardano-node's domain socket
   SocketPath ->